fix: warnings for 'c-run-time.c' #1706
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates different arities for DFLN.
typedef dylan_value (*DLFN0)(void);
typedef dylan_value (*DLFN1)(dylan_value);
typedef dylan_value (*DLFN2)(dylan_value, dylan_value);
... etc
Changing DLFN to a union
typedef union {
void* raw;
DLFN0 mep0;
DLFN1 mep1;
DLFN2 mep2;
DLFN3 mep3;
DLFN4 mep4;
DLFN5 mep5;
DLFN6 mep6;
DLFN7 mep7;
DLFN8 mep8;
DLFN9 mep9;
DLFN10 mep10;
DLFN64 mep64;
} DLFN;
Then rewrite the call logic using the correct
type per arity.
switch (teb->argument_count) {
case 0: return (mep.mep0)();
case 1: return (mep.mep1)(v[0]);
...
Closes dylan-lang#1650
|
If the premise isn't valid, please suggest an alternative and I'll start over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates different arities for DFLN.
typedef dylan_value (*DLFN0)(void);
typedef dylan_value (*DLFN1)(dylan_value);
typedef dylan_value (*DLFN2)(dylan_value, dylan_value);
... etc
Changing DLFN to a union
typedef union {
void* raw;
DLFN0 mep0;
DLFN1 mep1;
DLFN2 mep2;
DLFN3 mep3;
DLFN4 mep4;
DLFN5 mep5;
DLFN6 mep6;
DLFN7 mep7;
DLFN8 mep8;
DLFN9 mep9;
DLFN10 mep10;
DLFN64 mep64;
} DLFN;
Then rewrite the call logic using the correct
type per arity.
switch (teb->argument_count) {
case 0: return (mep.mep0)();
case 1: return (mep.mep1)(v[0]);
...
Closes #1650