Skip to content

prepare CRAN release #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
Merged

prepare CRAN release #342

merged 3 commits into from
Mar 4, 2025

Conversation

strengejacke
Copy link
Member

No description provided.

@strengejacke
Copy link
Member Author

@bwiernik Checks look good, I think a CRAN submission can be made from this PR.

@strengejacke
Copy link
Member Author

If you need any assistance for submission, let me know. The CRAN deadline is next week.

@bwiernik
Copy link
Contributor

bwiernik commented Mar 3, 2025

@strengejacke CRAN rejects with a NOTE because the examples in correlation.R contain the |> pipe, even though they are only shown if getRversion() >= "4.1.0".

Should we bump the minimum version up to 4.1.0?

@DominiqueMakowski
Copy link
Member

I don't mind

@DominiqueMakowski
Copy link
Member

Or you reply to Kurt with this gif

@bwiernik
Copy link
Contributor

bwiernik commented Mar 3, 2025

Is your laugh response agreement @strengejacke ? 😜

@strengejacke
Copy link
Member Author

strengejacke commented Mar 3, 2025

There are a few packages that import correlation. Some depend on R 2.1 (😆), which can't be met anyway. We can also fix the examples, I leave it to you what you prefer. I'm also fine with bumping to 4.1

@bwiernik
Copy link
Contributor

bwiernik commented Mar 3, 2025

The examples are specifically highlighting the "pipe-friendly" nature of the function, so there isn't a great way to "fix" them without removing. I'll bump.

@bwiernik bwiernik merged commit 9e2503b into main Mar 4, 2025
21 of 25 checks passed
@bwiernik bwiernik deleted the rc_0_8_7 branch March 4, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants