-
-
Notifications
You must be signed in to change notification settings - Fork 57
prepare CRAN release #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare CRAN release #342
Conversation
@bwiernik Checks look good, I think a CRAN submission can be made from this PR. |
If you need any assistance for submission, let me know. The CRAN deadline is next week. |
@strengejacke CRAN rejects with a NOTE because the examples in Should we bump the minimum version up to 4.1.0? |
I don't mind |
Is your laugh response agreement @strengejacke ? 😜 |
There are a few packages that import correlation. Some depend on R 2.1 (😆), which can't be met anyway. We can also fix the examples, I leave it to you what you prefer. I'm also fine with bumping to 4.1 |
The examples are specifically highlighting the "pipe-friendly" nature of the function, so there isn't a great way to "fix" them without removing. I'll bump. |
No description provided.