Replace isdigit with OMR_ISDIGIT #21555
Draft
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Apr 2, 2025
runtime/cfdumper/romdump.c
Outdated
| @@ -698,14 +700,14 @@ parseROMQuery(J9Pool *allocator, const char *query) | |||
|
|
|||
| if ('[' == *query) { | |||
| query++; | |||
| if (!isdigit(*query)) { | |||
| if (!__isdigit_a(*query)) { | |||
There was a problem hiding this comment.
Is this a function on z/OS? The code is common to all platforms and needs to compile on all of them.
There was a problem hiding this comment.
This should instead use OMR_ISDIGIT() once eclipse-omr/omr#7711 is merged.
|
@keithc-ca fyi |
|
I proposed a way forward in eclipse-omr/omr#7711 (comment). |
Deigue
changed the title
keithc-ca
reviewed
Apr 14, 2025
In order to support removal of a2e header redefinitions for isdigit() method, the usage of isdigit() are replaced with OMR_ISDIGIT() to properly recognize ascii digit literals. This is done by conditionally using __isdigit_a() on z/OS platforms. Signed-off-by: Gaurav Chaudhari <[email protected]>
keithc-ca
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support removal of a2e header redefinitions for
isdigit() method, the usage of isdigit() are replaced with
OMR_ISDIGIT() to properly recognize ascii digit literals.
This is done by conditionally using __isdigit_a() on z/OS
platforms.
Main PR driving this change, that needs to be merged alongside: eclipse-omr/omr#7413
(project tag: Open XL z/OS compiler support)