Add system processes event #21631
Open
Add system processes event #21631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture and store process `pid` and `commandLine` for JFR events.
tajila
reviewed
Apr 11, 2025
| @@ -502,6 +510,7 @@ class VM_JFRConstantPoolTypes { | |||
|
|
|||
| U_32 getMethodEntry(J9ROMMethod *romMethod, J9Class *ramClass); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
these extrsa blank lines are not needed
tajila
reviewed
Apr 11, 2025
| @@ -1246,6 +1266,41 @@ class VM_JFRConstantPoolTypes { | |||
| gcConfiguration->heapAddressBits = J9JAVAVM_REFERENCE_SIZE(vm) * 8; | |||
| } | |||
|
|
|||
| uintptr_t recordSystemProcessEvent(uintptr_t pid, const char *commandLine, void *userData) | |||
There was a problem hiding this comment.
you can make this a static so you dont need tempProcessCallback
tajila
reviewed
Apr 11, 2025
| char pidString[32]; | ||
| snprintf(pidString, sizeof(pidString), "%lu", (unsigned long)pid); | ||
| entry->pid = strdup(pidString); | ||
| entry->commandLine = strdup(commandLine); |
There was a problem hiding this comment.
also add a counter and keep track of the length of the string (+= strlen(commandLine)) so requiredBufferSize can be more accurate
tajila
reviewed
Apr 11, 2025
| _writer->writeStringLiteral(entry->pid); | ||
|
|
||
| /* Write command line */ | ||
| _writer->writeStringLiteral(entry->commandLine); |
There was a problem hiding this comment.
you can free and NULL the string after you write it to the chunk
|
Please add a test case to validate the event is emitted in jfr_events.xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture and store process
pidandcommandLinefor JFR system processes events events.