Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PoSt partition batching #813

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Mar 28, 2025

Description

Partition Index in PoSt generation was unused, I thought that's an issue and it's not.
k is local to each pair of the verification/generation batch.
If we have 20 partitions to prove, two batches of 10 partitions, k = 0..10 in each batch.

Anyways, this PR reduces the PoSt partition batches to 1 per call, as this is max we can verify with our partition sizes given the block time. I changed the constants to reflect that.

Closes #787.

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Were there any alternative implementations considered?
    • Yes, we could make the partition index be consistent with the 'global partition index' stored in the SP deadline, but after analysis I deem those changes too big and not worth it.
  • Did you document new (or modified) APIs?

@th7nder th7nder added the bug Something isn't working label Mar 28, 2025
@th7nder th7nder added this to the Phase 3 milestone Mar 28, 2025
@th7nder th7nder self-assigned this Mar 28, 2025
@th7nder th7nder added the ready for review Review is needed label Mar 28, 2025
@th7nder th7nder mentioned this pull request Mar 28, 2025
55 tasks
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Mar 28, 2025
@jmg-duarte jmg-duarte merged commit ab2980e into develop Mar 31, 2025
10 of 12 checks passed
@jmg-duarte jmg-duarte deleted the fix/787/fix-post-generation-for-partitions branch March 31, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Windowed PoSt generation partition aware
3 participants