Refactor storage-provider-client #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Åström <[email protected]>
Signed-off-by: Lucas Åström <[email protected]>
th7nder
approved these changes
Apr 2, 2025
|
Additional context I forgot to mention: The reason behind the change is not just cosmetic, it's to be able to internally call these functions in an upcoming CLI function. |
jmg-duarte
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing on the theme of non-offensive easy-to-merge PRs, this one just splits out the CLI commands in storage-provider-client and uses
json!instead offormat!for the output of the CommP. The diff is a bit difficult to parse on GitHub, but it's a bit easier to see in VSCode (and probably other editors with move detection).Important points for reviewers
There should be no functionality or even code changes outside of extracting functions and the one json change.
Checklist
[] If there are follow-ups, have you created issues for them?[ ] Have you tested this solution?[ ] Were there any alternative implementations considered?[ ] Did you document new (or modified) APIs?