feat: add support for express v5

[david-luna]

Checklist

• Implement code
• Update tests
• Update documentation
• Add release notes to docs/release-notes/index.md
• Commit message follows commit guidelines

[trentm]

LGTM, after the cloud-metadata-fetcher test change we discussed (to skip that using _is_express_incompat.js.

[david-luna]

LGTM, after the cloud-metadata-fetcher test change we discussed (to skip that using _is_express_incompat.js.

I set myself a challenge to try to replace express in that test. The result is in c16773e

Let me know what you think. It's okay for me to just skip

[david-luna]

/test tav express

[david-luna]

@trentm there are other tests that depend on express in order to provide a mock server. Some examples

apm-agent-nodejs/test/instrumentation/modules/aws-sdk/dynamodb.test.js

Line 27 in cd398aa

const express = require('express');

apm-agent-nodejs/test/instrumentation/modules/aws-sdk/sns.test.js

Line 29 in cd398aa

const express = require('express');

apm-agent-nodejs/test/instrumentation/modules/http/disabling.test.js

Line 160 in cd398aa

const express = require('express');

apm-agent-nodejs/test/instrumentation/modules/http/request.test.js

Line 46 in cd398aa

var app = express();

apm-agent-nodejs/test/lambda/wrapper.test.js

Line 165 in cd398aa

const express = require('express');

it is also used in lambda. I wouldn't hesitate to disable 1 or 2 but there are a few more. Also they affect other technologies and features like lambda.

[trentm]

LGTM, with some nits.

[david-luna]

note for reviewer: looking at https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html I thought it is okay to skip tests for lambda.

[david-luna]

/test tav

[david-luna]

There are a couple of errors but seem unrelated:

• elasticsearch tav is failing due to a version mismatch between service and client
• pg tav seems to have ESM issues
• apollo-express tav seesm to test on a version of apollo server where ApolloServer.start method is not there. Actually we're testing different versions than main (that's the issue here)

[david-luna]

/test tav apollo-server-express

[david-luna]

apollo-server-express TAV is passing now https://github.com/elastic/apm-agent-nodejs/actions/runs/14733994570/job/41355299943?pr=4581

[david-luna]

/test tav

[david-luna]

note to reviewer: i think this is related to the fact [email protected] added support for ESM imports. ref: https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md#pg8150

[trentm]

Yes, it is because its package.json uses "exports" now: https://github.com/brianc/node-postgres/blob/980752ce003b466a691d394e177c7d33a869e960/packages/pg/package.json#L22-L33

[trentm]

Some nits. Mainly the docs/release-notes/index.md thing should get corrected.