Revert "Enable madvise by default for all builds (#110159)" #126308
Conversation
This reverts commit 4a77e06.
ChrisHegarty
added
Team:Performance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
v8.19.0
and removed
Team:Performance
| @@ -36,6 +37,8 @@ | |||
|
|
|||
| public class FsDirectoryFactory implements IndexStorePlugin.DirectoryFactory { | |||
|
|
|||
| private static final FeatureFlag MADV_RANDOM_FEATURE_FLAG = new FeatureFlag("madv_random"); | |||
There was a problem hiding this comment.
It seems ok to keep the feature flag, since it could be enabled in non-vector scenarios. But I'm also ok to either just remove it or replace it with a system property, if we wanna retain the ability to enable this but not even have it on-by-default in snapshot builds.
There was a problem hiding this comment.
@ChrisHegarty if we wish to tranform it into a regular system property, we can do that in a separate PR. However, I am not sure we want to expose it at all in v8.x as its incredibly trappy.
| @@ -36,6 +37,8 @@ | |||
|
|
|||
| public class FsDirectoryFactory implements IndexStorePlugin.DirectoryFactory { | |||
|
|
|||
| private static final FeatureFlag MADV_RANDOM_FEATURE_FLAG = new FeatureFlag("madv_random"); | |||
There was a problem hiding this comment.
@ChrisHegarty if we wish to tranform it into a regular system property, we can do that in a separate PR. However, I am not sure we want to expose it at all in v8.x as its incredibly trappy.
This reverts commit 4a77e06. We've seen a significant performance degradation in merging vectors resulting from the use of MADV_RANDOM and MGLRU ( and LRU in recent Linux kernels ) For the 8.x release train, then we will revert the change that enabled MADV_RANDOM. And backport to all shipping 8.x bugfix releases. relates: #124499
This reverts commit 4a77e06. We've seen a significant performance degradation in merging vectors resulting from the use of MADV_RANDOM and MGLRU ( and LRU in recent Linux kernels ) For the 8.x release train, then we will revert the change that enabled MADV_RANDOM. And backport to all shipping 8.x bugfix releases. relates: #124499
This reverts commit 4a77e06. We've seen a significant performance degradation in merging vectors resulting from the use of MADV_RANDOM and MGLRU ( and LRU in recent Linux kernels )
For the 8.x release train, then we will revert the change that enabled MADV_RANDOM. And backport to all shipping 8.x bugfix releases.
For 9.x the perf regression is less significant, and we will continue to investigate a more complete solution within Lucene, see, apache/lucene#14408.
relates: #124499