Return float[] instead of List<Double> in valueFetcher for rank_vectors #126702
+35
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>enhancement
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @iverase, I've created a changelog YAML for you. |
benwtrent
reviewed
Apr 11, 2025
...ectors/src/main/java/org/elasticsearch/xpack/rank/vectors/mapper/RankVectorsFieldMapper.java
Show resolved
Hide resolved
benwtrent
reviewed
Apr 11, 2025
...ectors/src/main/java/org/elasticsearch/xpack/rank/vectors/mapper/RankVectorsFieldMapper.java
Outdated
Show resolved
Hide resolved
...ors/src/test/java/org/elasticsearch/xpack/rank/vectors/mapper/RankVectorsFieldTypeTests.java
Show resolved
Hide resolved
Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>
Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>
benwtrent
approved these changes
Apr 14, 2025
iverase
added
the
auto-backport
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Apr 15, 2025
We are currently having to hold in heap big list of Double objects which can take big amounts of heap. With this change we can reduce the heap usage by 7x.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2025
iverase
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently having to hold in heap big list of Double objects which can take big amounts of heeap. With this change we can reduce the heap usage by 7x.