-
Notifications
You must be signed in to change notification settings - Fork 451
[Servicenow] Add support to append sysparm query
in CEL input
#13621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Servicenow] Add support to append sysparm query
in CEL input
#13621
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
Co-authored-by: Shourie Ganguly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock, but I still feel we should handle the trailing tokens in a more graceful manner. Having dead tokens as a suffix does not seem right, even if the API handles it.
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package servicenow - 0.13.0 containing this change is available at https://epr.elastic.co/package/servicenow/0.13.0/ |
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
Related issues