Skip to content

[fortinet_fortigate] Add deltabytes field, ensure rcvddelta and sentdelta fields are integers #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[fortinet_fortigate] Add deltabytes field, ensure rcvddelta and sentdelta fields are integers #13668

wants to merge 3 commits into from

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 24, 2025 •
edited
Loading

Proposed commit message

  • Changed rcvddelta and sentdelta fields to long type, added convert processors
  • Added new fortinet.firewall.deltabytes field, which is the sum of the rcvddelta and senddelta fields

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/fortinet_fortigate
elastic-package test

Related issues

@taylor-swanson
[fortinet_fortigate] Add deltabytes field, ensure rcvddelta and sentd…
edb4f72 
…elta fields are integers

- Changed rcvddelta and sentdelta fields to long type, added convert processors
- Added new fortinet.firewall.deltabytes field, which is the sum of the rcvddelta and senddelta fields
@taylor-swanson
changelog
1844224
@taylor-swanson taylor-swanson self-assigned this Apr 24, 2025
@taylor-swanson taylor-swanson added enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 24, 2025
@taylor-swanson taylor-swanson mentioned this pull request Apr 24, 2025
Open
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson taylor-swanson marked this pull request as ready for review April 24, 2025 14:16
@taylor-swanson taylor-swanson requested a review from a team as a code owner April 24, 2025 14:16
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@taylor-swanson taylor-swanson

Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
2 participants
@taylor-swanson @elasticmachine