-
Notifications
You must be signed in to change notification settings - Fork 175
[synthetics] Add lightweight monitor configuration options #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A documentation preview will be available soon: |
I'm not sure if the example on the initial page might be a bit confusing? For instance, https://observability-docs_2729.docs-preview.app.elstc.co/guide/en/observability/master/synthetics-lightweight.html#synthetics-lightweight talks about the different types of monitor, with links to how to go and set those up (which I think works). The section beneath though shows an example YML, but it's not necessarily clear what that relates to (e.g. someone can't use those if they are configuring through the UI). Maybe the common/http/icmp/tcp/data-types pages should be linked to from Project Monitors for example. I wonder if it will be easier to understand that with the split of the docs between Synthetics and Uptime/Heartbeat too. Be interested to hear from @andrewvc too on how this fits in with what he had in mind initially too. |
There is a gap between the configurations in the UI, Project Monitors, and traditional We have a variety of issues to close this gap, but it will take time, they are:
The full set is the current implementation in I think that adding all these options under Synthetics will be confusing as many configurations are not supported. I think the UI does a good job of describing the various configurations (and as we add them, this will continue). That leaves Project Monitors, for which it is not clear what options are supported. @andrewvc what were your thoughts here, should this be something like:
|
This is certainly a complex issue, I think the guiding principle here should be that we should remove the need for most users to look at the heartbeat docs. That means that we should document the YAML for lightweight monitors enough to cover at 95% of use cases. I think your last comments are dead on in aligning with that @paulb-elastic . No need to document the UI, and just document the available config options for project monitors, making it clear that they only affect the YAML options for project monitors. |
Thanks @paulb-elastic @andrewvc! Is the latest preview looking closer to what you're describing? If yes, next up is to determine if we should replace all instances of the word "Heartbeat".
The copied-over content from the Heartbeat docs references "Heartbeat" several times. Should we replace it as to not confuse users? What is the right replacement... "Synthetics"? Here are a couple examples:
Yes. It will be a bit of a challenge to keep these docs up to dat, but I structured the tables of options in a way that (hopefully) in the future we could generate docs from structured data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To expand on my previous comment, I've added some specific questions I'd like to get answers to in order to move this PR forward. @paulb-elastic who's the best point of contact for this PR?
docs/en/observability/synthetics-reference/lightweight-config/common.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/synthetics-reference/lightweight-config/common.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/synthetics-reference/lightweight-config/common.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/synthetics-reference/lightweight-config/http.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/synthetics-reference/lightweight-config/http.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/synthetics-reference/lightweight-config/tcp.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…2824) * copy-paste from beats * add data types * format and edit common options * fix links * update structure * clean up * add links * address feedback from @andrewvc * address remaining feedback, clean up * fix tiny typo (cherry picked from commit c4af37c) Co-authored-by: Colleen McGinnis <[email protected]>
//////////////////////// | ||
| [[monitor-enabled]] *`enabled`* | ||
(<<synthetics-lightweight-data-bool,boolean>>) | ||
a| Whether the module is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: module -> monitor
Closes #2372
Approach
This is still a work in progress, but here's the plan:
Open questions
In the original issue, @andrewvc mentioned:
How far do we want to take this? Do we not want to link back to any Heartbeat-related docs? If so, we would need to also copy (or single-source) content that is linked to from these reference pages. For example, if
processors
is a supported config option, users would probably need to know how processors can be defined.Feel free to tag in others to provide feedback!