Skip to content

fix: omit playwright-core from bundles !! #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: omit playwright-core from bundles !! #986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/push/bundler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class Bundler {
write: false,
minifyWhitespace: true,
sourcemap: 'inline',
external: ['@elastic/synthetics'],
external: ['@elastic/synthetics', 'playwright-core'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do this, but we would end up creating broken experience for the users if they decided to pull some code from PW.

Allowing this is better for the UX side than having a broken experience. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better way would be to disallow it as per your PR and have a symbolic link in the Heartbeat side when we set up project monitors so we dont have a broken experience for users.

plugins: [SyntheticsBundlePlugin()],
},
};
Expand Down
Loading