Move specific Synapse config out of RootConfig
#18410
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move specific Synapse config out of
RootConfig
. Spawning from wanting to import and re-use theRootConfig
/Config
machinery in another project.server_name
andreport_stats
are Synapse specific and not useful to other applications. I also think they make more sense to be validated in the appropriate config files instead of root.Testing strategy
Test missing
server_name
config:server_name
in yourhomserver.yaml
poetry run synapse_homeserver --config-path homeserver.yaml
Test missing
report_stats
config:report_stats
in yourhomserver.yaml
poetry run synapse_homeserver --config-path homeserver.yaml
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)