Learned patterns

.cursor/rules/gmail-api.mdc

@@ -0,0 +1,67 @@
+---
+description: Guidelines for working with Gmail API
+globs: 
+alwaysApply: false
+---
+# Gmail API Usage
+
+Guidelines for working with email provider APIs (Gmail, Outlook, etc.) to ensure maintainability and future provider support.
+Currently we only support Gmail.
+
+## Core Principles
+
+1. **Never call provider APIs directly from routes or components**
+2. **Always use wrapper functions from the utils folder**
+3. **Keep provider-specific implementation details isolated**
+
+## Directory Structure
+
+```
+apps/web/utils/
+├── gmail/           # Gmail-specific implementations
+│   ├── message.ts   # Message operations (get, list, batch, etc.)
+│   ├── thread.ts    # Thread operations
+│   ├── label.ts     # Label operations
+│   └── ...
+├── outlook/         # Future Outlook implementation
+└── ...              # Other providers
+```
+
+## Usage Patterns
+
+### ✅ DO: Use the abstraction layers
+
+```typescript
+// GOOD: Using provided utility functions
+import { getMessages, getMessage } from "@/utils/gmail/message";
+
+async function fetchEmails(gmail: gmail_v1.Gmail, query: string) {
+  // Use the wrapper function that handles implementation details
+  const messages = await getMessages(gmail, {
+    query,
+    maxResults: 10,
+  });
+
+  return messages;
+}
+```
+
+### ❌ DON'T: Call provider APIs directly
+
+```typescript
+// BAD: Direct API calls
+async function fetchEmails(gmail: gmail_v1.Gmail, query: string) {
+  // Direct API calls make future provider support difficult
+  const response = await gmail.users.messages.list({
+    userId: "me",
+    q: query,
+    maxResults: 10,
+  });
+
+  return response.data;
+}
+```
+
+## Why This Matters
+
+1. **Future Provider Support**: By isolating provider-specific implementations, we can add support for Outlook, ProtonMail, etc.

.cursor/rules/llm-test.mdc

@@ -31,15 +31,15 @@ Tests for LLM-related functionality should follow these guidelines to ensure con
    // Skip tests unless explicitly running AI tests
    const isAiTest = process.env.RUN_AI_TESTS === "true";
 
-   describe.skipIf(!isAiTest)("yourFunction", () => {
+   describe.runIf(isAiTest)("yourFunction", () => {
      beforeEach(() => {
        vi.clearAllMocks();
      });
 
      test("test case description", async () => {
        // Test implementation
      });
-   });
+   }, 15_000);
    ```
 
 ## Helper Functions

apps/web/__tests__/ai-categorize-senders.test.ts

@@ -51,7 +51,7 @@ const testSenders = [
   },
 ];
 
-describe.skipIf(!isAiTest)("AI Sender Categorization", () => {
+describe.runIf(isAiTest)("AI Sender Categorization", () => {
   describe("Bulk Categorization", () => {
     it("should categorize senders with snippets using AI", async () => {
       const result = await aiCategorizeSenders({

apps/web/__tests__/ai-choose-args.test.ts

@@ -9,7 +9,7 @@ const isAiTest = process.env.RUN_AI_TESTS === "true";
 
 vi.mock("server-only", () => ({}));
 
-describe.skipIf(!isAiTest)("getActionItemsWithAiArgs", () => {
+describe.runIf(isAiTest)("getActionItemsWithAiArgs", () => {
   test("should return actions unchanged when no AI args needed", async () => {
     const actions = [getAction({})];
     const rule = getRule("Test rule", actions);

apps/web/__tests__/ai-choose-rule.test.ts

@@ -9,7 +9,7 @@ const isAiTest = process.env.RUN_AI_TESTS === "true";
 
 vi.mock("server-only", () => ({}));
 
-describe.skipIf(!isAiTest)("aiChooseRule", () => {
+describe.runIf(isAiTest)("aiChooseRule", () => {
   test("Should return no rule when no rules passed", async () => {
     const result = await aiChooseRule({
       rules: [],

apps/web/__tests__/ai-create-group.test.ts

@@ -13,7 +13,7 @@ vi.mock("@/utils/gmail/message", () => ({
   queryBatchMessages: vi.fn(),
 }));
 
-describe.skipIf(!isAiTest)("aiGenerateGroupItems", () => {
+describe.runIf(isAiTest)("aiGenerateGroupItems", () => {
   it("should generate group items based on user prompt", async () => {
     const user = {
       email: "[email protected]",