Skip to content

fix: readd lost custom errors #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: readd lost custom errors #182

wants to merge 3 commits into from

Conversation

Nidhi091999
Copy link
Contributor

@Nidhi091999 Nidhi091999 commented Jan 20, 2025

Issue: #168

Summary by Sourcery

Add InputUriError and IPDistanceCalculationError exceptions, and add a TesUriError exception.

New Features:

  • Added InputUriError for signaling invalid input URIs.
  • Added IPDistanceCalculationError for when IP distance calculation fails.
  • Added TesUriError for when a TES URI cannot be parsed.

Summary by Sourcery

Reintroduce and define custom error classes for specific error scenarios in the exceptions module

New Features:

  • Added custom error classes for TES URI parsing
  • Added custom error classes for input URI parsing
  • Added custom error class for IP distance calculation failures

Bug Fixes:

  • Restored previously lost custom error exceptions

Copy link

sourcery-ai bot commented Jan 20, 2025

Reviewer's Guide

This pull request re-introduces three custom exception classes (InputUriError, IPDistanceCalculationError, TesUriError) by defining them in pro_tes/exceptions.py and registering them in the exceptions dictionary with associated messages and HTTP status codes.

Class diagram for new exception types

classDiagram
    ValueError <|-- InputUriError
    note for InputUriError "Added in this PR"
    ValueError <|-- IPDistanceCalculationError
    note for IPDistanceCalculationError "Added in this PR"
    ValueError <|-- TesUriError
    note for TesUriError "Added in this PR"
Loading

File-Level Changes

Change Details Files
Added custom exception classes and registered them.
  • Defined TesUriError, InputUriError, and IPDistanceCalculationError inheriting from ValueError.
  • Added entries for the new exceptions in the exceptions dictionary, mapping them to error messages and HTTP status codes (400 or 500).
pro_tes/exceptions.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Nidhi091999 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the PR description with details about the motivation for these new exceptions and reference any related issues.
  • The exceptions dictionary entries should maintain consistency - TesUriError and IPDistanceCalculationError are missing HTTP status codes while other entries have them.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -94,4 +102,14 @@ class InvalidMiddleware(MiddlewareException):
"message": "Middleware is invalid.",
"code": "500",
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Missing error code for TesUriError and IPDistanceCalculationError exceptions

Other exceptions in the dictionary include both 'message' and 'code' fields. Consider adding appropriate error codes to maintain consistency in error handling.

@uniqueg
Copy link
Member

uniqueg commented Mar 5, 2025

Let's get to this after the repo is fixed again (broken tests) and after #184 is merged :)

@uniqueg uniqueg marked this pull request as draft May 2, 2025 13:37
@uniqueg uniqueg changed the title Draft: Added InputUriError and IPDistanceCalculationError fix: readd InputUriError and IPDistanceCalculationError May 2, 2025
@uniqueg uniqueg changed the title fix: readd InputUriError and IPDistanceCalculationError fix: readd lost custom errors May 2, 2025
@Nidhi091999 Nidhi091999 marked this pull request as ready for review May 5, 2025 08:30
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Nidhi091999 - I've reviewed your changes - here's some feedback:

  • Consider inheriting the new custom exceptions from a shared base exception class specific to this application for better error categorization.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants