Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: the benchmark below was checking for an invalid string - discard and see sabiwara/elixir_benches@af34130 (still quite a nice speedup)
and
instead of relying on a globalrescue
has a significant impactrescue
to check if the char is a non-nil member of a tuple also has almost as big of an impactI haven't benched/done other functions yet, wanted to first share this one and wait for the feedback.
Reusing @whatyouhide 's
big_string
benchmark: