Silence sass errors #1674
Merged
Silence sass errors #1674
+25
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalBryxi
force-pushed
the
mb/1673-silence-sass-errors
branch
from
6d3449a to
e0106bc
Compare
It's not possible to migrate away from `@import` because:
```
pnpx sass-migrator module --migrate-deps addon/styles/addon.scss
...
Error: This stylesheet was loaded by a nested import in addon/styles/addon.scss. The module system only supports loading nested CSS using the load-css() mixin, which doesn't allow access to variables from the outer stylesheet.
╷
2 │ width: calc(((100% - #{$site-container}) / 2) + 14rem);
│ ^^^^^^^^^^^^^^^
╵
addon/styles/components/_docs-viewer-x-current-page-index.scss 2:26 root stylesheet
```
This finally silences: ``` [test:ember] [test:ember] ╷ [test:ember] 9 │ @import './tailwind/components/docs-btn'; [test:ember] │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [test:ember] ╵ [test:ember] addon/styles/addon.scss#sass 9:9 root stylesheet [test:ember] [test:ember] DEPRECATION WARNING: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0. ``` Fixes: ember-learn#1673
MichalBryxi
force-pushed
the
mb/1673-silence-sass-errors
branch
from
e0106bc to
07a725c
Compare
|
@SergeAstapov This one is ready to merge. Atomic commits with good-ish explanation of what is happening there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally silences:
Fixes: #1673