fix link to changelog on releases of Ember >6.0.0 #1150
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| return `https://github.com/${this.repo}/blob/v${this.lastRelease}/${this.changelogPath}`; | ||
| const tagName = this.tagName ?? `v${this.lastRelease}`; | ||
|
|
||
| return `https://github.com/${this.repo}/blob/${tagName}/${this.changelogPath}`; |
There was a problem hiding this comment.
Wonder if we could just hardcode it to add the -ember-source suffix.
Would avoid requiring updating an extra property to be manually.
@mansona perhaps you know if it will always be the case now? (I know we're experimenting with release-plan, but not sure if this is related)
There was a problem hiding this comment.
Yes indeed. We do the same here:
https://github.com/ember-learn/ember-api-docs/blob/main/app/helpers/github-link.js#L10
There was a problem hiding this comment.
But what if ember-data or some other package changes the tagging strategy? Do we want to have an if block for each package? Why not put that in the data then?
Or update the project data to have a tag format that uses other properties to generate the tag:
...
repo: emberjs/ember.js
packageName: ember-source # For monorepos / workspaces
lastRelease: 6.4.0 # Manually update, see https://libraries.io/npm/ember-source throughout
tagFormat: v{{lastRelease}}-{{packageName}}
...So adding a packageName for monorepos (can also be good for other links) and a tagFormat that specifies how to make up the tag?
No description provided.