Skip to content

fix 'set EM_PY' in batch files #23903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Mar 12, 2025

This fixes the following error:

  '"python"' is not recognized as an internal or external command,

This is not usually triggered because usually EMSDK_PYTHON is set.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are all auto-generated by create_entry_points.py, so if you want to make changes that is the place to start.

Does cmd.exe not look for python.exe automatically when you type just python?

Isn't it better to use the bare python string since then the cmd.exe shell will also look for things like python.bat and python.com?

@fs-eire
Copy link
Contributor Author

fs-eire commented Mar 12, 2025

Does cmd.exe not look for python.exe automatically when you type just python?

Isn't it better to use the bare python string since then the cmd.exe shell will also look for things like python.bat and python.com?

I ran into this issue when trying to use vcpkg with emscripten in my project. I don't know much about this parts so not sure about the answer to your questions. The direct error I saw is emcc.bat failed because of the error.

Let me do some further investigation.

@sbc100
Copy link
Collaborator

sbc100 commented Mar 12, 2025

Does cmd.exe not look for python.exe automatically when you type just python?
Isn't it better to use the bare python string since then the cmd.exe shell will also look for things like python.bat and python.com?

I ran into this issue when trying to use vcpkg with emscripten in my project. I don't know much about this parts so not sure about the answer to your questions. The direct error I saw is emcc.bat failed because of the error.

Let me do some further investigation.

How are you installing/using emscripten? Are you not using emsdk?

Where is python.exe coming from on your system? i.e what does where python say?

@fs-eire fs-eire marked this pull request as draft March 14, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants