Deprecate EMULATE_FUNCTION_POINTER_CASTS setting #23953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who use this setting will now see the following warning: ``` emcc: warning: EMULATE_FUNCTION_POINTER_CASTS is deprecated (no known users). Please open a bug if you have a continuing need for this setting [-Wdeprecated] ``` See emscripten-core#23952
sbc100
force-pushed
the
EMULATE_FUNCTION_POINTER_CASTS
branch
from
a1b4b5c to
d94b48d
Compare
kripken
approved these changes
Mar 19, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 22, 2025
This change effectively reverts emscripten-core#23953 It turns out there is an ongoing need for this in the glib project: See https://gitlab.gnome.org/GNOME/glib/-/issues/3670 and https://gitlab.gnome.org/GNOME/glib/-/blob/main/docs/toolchain-requirements.md?ref_type=heads#calling-functions-through-differently-typed-function-pointers Fixes: emscripten-core#23952
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 22, 2025
This change effectively reverts emscripten-core#23953 It turns out there is an ongoing need for this in the glib project: See https://gitlab.gnome.org/GNOME/glib/-/issues/3670 and https://gitlab.gnome.org/GNOME/glib/-/blob/main/docs/toolchain-requirements.md?ref_type=heads#calling-functions-through-differently-typed-function-pointers Fixes: emscripten-core#23952
sbc100
added a commit
that referenced
this pull request
Apr 23, 2025
This change effectively reverts #23953 It turns out there is an ongoing need for this in the glib project: See https://gitlab.gnome.org/GNOME/glib/-/issues/3670 and https://gitlab.gnome.org/GNOME/glib/-/blob/main/docs/toolchain-requirements.md?ref_type=heads#calling-functions-through-differently-typed-function-pointers Fixes: #23952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who use this setting will now see the following warning:
See #23952