Fix regression with instantiateWasm + MODULARIZE + Asyncify #24032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating to the latest emcc, I found a regression that affects MODULARIZE + Asyncify, but not only. I bisected and identified the problematic set of commits:
https://chromium.googlesource.com/external/github.com/emscripten-core/emscripten.git/+log/7924a238f187..ec40bc528ea6
As you can see, in these changes, instantiateWasm resolves with mod.exports, which is incorrect because receiveInstance modifies the exports and returns the modified version. For example, in the case of Asyncify, using the original exports leads to exceptions inside the Asyncify code because the exports are not instrumented.
The fix is trivial—if you agree with my assessment, I can also add a test case.