Skip to content

cleanup code and update dependencies #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marinkobabic
Copy link

Clean up many warning of the flutter linter and increase library versions

@petrleocompel
Copy link

petrleocompel commented Feb 24, 2025

A lot of changes was done just by dart fix. Would rather see that as multiple separate commits not to put it together with manual changes and "libraries" update.

Also the message is not according conventional commits. I know we do not have Guidelines / contributions README file but it is pretty clear from the commit messages before.

I am happy to see a contribution and really I see some things which I overlooked like

  • commit of cryptography_flutter_integration_test/macos/Flutter/GeneratedPluginRegistrant.swift (not sure if it should be commited) and the wrong library mention
  • cryptography_test/pubspec.yaml having wrong version non-existing version.

Otherwise jwk/pubspec.yaml upgrading the collections is not necessary neither maybe wanted. As until it is needed or necessary I am for keeping these back and allow the constraint to install newer versions.

@@ -7,12 +7,12 @@ environment:
sdk: ">=3.1.0 <4.0.0"

dependencies:
collection: ^1.17.0
collection: ^1.19.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is unnecessary


#
# Packages by github.com/dint-dev:
#
cryptography_plus: ^2.5.1
cryptography_plus: ^2.7.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good correction. Version 2.5.1 does not exist for cryptography_plus

@@ -5,7 +5,7 @@
import FlutterMacOS
import Foundation

import cryptography_flutter
import cryptography_flutter_plus

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is generated. But It was overlooked but still.. But also it might should not be even commited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants