-
Notifications
You must be signed in to change notification settings - Fork 6
cleanup code and update dependencies #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
A lot of changes was done just by Also the message is not according conventional commits. I know we do not have Guidelines / contributions README file but it is pretty clear from the commit messages before. I am happy to see a contribution and really I see some things which I overlooked like
Otherwise |
@@ -7,12 +7,12 @@ environment: | |||
sdk: ">=3.1.0 <4.0.0" | |||
|
|||
dependencies: | |||
collection: ^1.17.0 | |||
collection: ^1.19.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is unnecessary
|
||
# | ||
# Packages by github.com/dint-dev: | ||
# | ||
cryptography_plus: ^2.5.1 | ||
cryptography_plus: ^2.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good correction. Version 2.5.1 does not exist for cryptography_plus
@@ -5,7 +5,7 @@ | |||
import FlutterMacOS | |||
import Foundation | |||
|
|||
import cryptography_flutter | |||
import cryptography_flutter_plus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is generated. But It was overlooked but still.. But also it might should not be even commited
Clean up many warning of the flutter linter and increase library versions