Refactor get_version to use a context manager for safe file handling #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
reviewed
Mar 26, 2025
- Replaced open() and os.path.join() with Path.read_text() for simplicity and readability.
mahdirahimi1999
force-pushed
the
fix/context-manager-get-version
branch
from
29b5b97 to
f0e2746
Compare
|
Please check this PR. @tomchristie |
auvipy
approved these changes
Mar 27, 2025
ulgens
approved these changes
Mar 27, 2025
|
Hi @auvipy, |
|
Closing in line with eg. #9666 (comment) In a different context it's a reasonable pull request. As it stands we're putting in place some clear boundaries to minimise unneccessary busy-work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
get_versionto use a context manager for safe file handlingThis PR updates the
get_versionfunction to use a context manager (with open(...)) when reading the__init__.pyfile.🔹 Key Improvements:
encoding='utf-8'for better compatibility across different systems.This is a small but useful refactor to improve code reliability.