Skip to content

Use openssl instead of ring. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use openssl instead of ring. #1

wants to merge 1 commit into from

Conversation

eoger
Copy link
Owner

@eoger eoger commented Apr 25, 2018

We are using rust-hawk in some applications that have a dependency on rust-openssl for different reasons.
rust-hawk itself depends on ring (2.2mb compiled with cargo build --release) for operations that could be done with rust-openssl instead, hence this PR.

@thomcc
Copy link

thomcc commented Apr 25, 2018

Echoing what I said in IRC for posterity -- I think we should be more careful about unwraps, and either know for sure they're safe, or expose them as Results to the caller. It is annoying that rust-openssl and ring are not fallible for the same operations, certainly.

I also dunno if we want to maintain a fork we never upstream for this. If we're upstreaming it then we might want to reach out to the maintainer and ask if they'd accept this -- if it were me I would want this implemented as a feature.

If this is too much work then maybe we can put off worrying about it until we get things working, though.

@eoger eoger force-pushed the use-openssl branch 2 times, most recently from c5a9aa2 to e04460d Compare April 25, 2018 18:25
@eoger
Copy link
Owner Author

eoger commented Apr 25, 2018

Unwraps removed, thanks!
I think we should put this work under a feature and upstream it once rust-lang/cargo#1839 is resolved:
We want to depend on ring if use-ring is specified, and openssl if use-openssl is specified.
Optional dependencies would make this crate clunky to use imo.

@eoger eoger closed this Jul 25, 2019
@eoger eoger deleted the use-openssl branch July 25, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants