Skip to content

feat: Update Baseline data #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

feat: Update Baseline data #130

merged 3 commits into from
May 15, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented May 12, 2025

Prerequisites checklist

What is the purpose of this pull request?

Update Baseline data

What changes did you make? (Give an overview)

  • upgraded mdn-data, compute-baseline, and web-features
  • updated use-baseline tests to pass using new data

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage May 12, 2025
@nzakas nzakas marked this pull request as ready for review May 12, 2025 19:04
@@ -10,7 +10,7 @@ export const BASELINE_LOW = 5;
export const BASELINE_FALSE = 0;

export const properties = new Map([
["accent-color", "0:"],
["accent-color", "10:2022"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-blocking) FYI the failing tests are due to web-platform-dx/web-features#2880. I'd expect the status for accent-color to go back to "false" once that's resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. I wasn't sure if it was incorrect before or incorrect now. 😄

The nice thing is that I can just manually edit this without waiting for that issue to be resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual override should no longer be necessary after updating to [email protected] 👍

@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage May 13, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 13, 2025
@nzakas nzakas merged commit 86aad6b into main May 15, 2025
22 checks passed
@nzakas nzakas deleted the update-basline branch May 15, 2025 15:46
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants