Skip to content

Commit 321313b

Browse files
authored
Merge pull request kubernetes#69004 from mgdevstack/master-pods-websocket-conformance
Promote pod's websocket based NodeConformance tests to Conformance
2 parents 1d2e10c + 78a15ed commit 321313b

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

test/conformance/testdata/conformance.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ test/e2e/common/pods.go: "should be submitted and removed"
111111
test/e2e/common/pods.go: "should be updated"
112112
test/e2e/common/pods.go: "should allow activeDeadlineSeconds to be updated"
113113
test/e2e/common/pods.go: "should contain environment variables for services"
114+
test/e2e/common/pods.go: "should support remote command execution over websockets"
115+
test/e2e/common/pods.go: "should support retrieving logs from the container over websockets"
114116
test/e2e/common/projected.go: "should be consumable from pods in volume"
115117
test/e2e/common/projected.go: "should be consumable from pods in volume with defaultMode set"
116118
test/e2e/common/projected.go: "should be consumable from pods in volume as non-root with defaultMode and fsGroup set"

test/e2e/common/pods.go

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,13 @@ var _ = framework.KubeDescribe("Pods", func() {
472472
}, maxRetries, "Container should have service environment variables set")
473473
})
474474

475-
It("should support remote command execution over websockets [NodeConformance]", func() {
475+
/*
476+
Release : v1.13
477+
Testname: Pods, remote command execution over websocket
478+
Description: A Pod is created. Websocket is created to retrieve exec command output from this pod.
479+
Message retrieved form Websocket MUST match with expected exec command output.
480+
*/
481+
framework.ConformanceIt("should support remote command execution over websockets [NodeConformance]", func() {
476482
config, err := framework.LoadConfig()
477483
Expect(err).NotTo(HaveOccurred(), "unable to get base config")
478484

@@ -548,7 +554,13 @@ var _ = framework.KubeDescribe("Pods", func() {
548554
}, time.Minute, 10*time.Second).Should(BeNil())
549555
})
550556

551-
It("should support retrieving logs from the container over websockets [NodeConformance]", func() {
557+
/*
558+
Release : v1.13
559+
Testname: Pods, logs from websockets
560+
Description: A Pod is created. Websocket is created to retrieve log of a container from this pod.
561+
Message retrieved form Websocket MUST match with container's output.
562+
*/
563+
framework.ConformanceIt("should support retrieving logs from the container over websockets [NodeConformance]", func() {
552564
config, err := framework.LoadConfig()
553565
Expect(err).NotTo(HaveOccurred(), "unable to get base config")
554566

0 commit comments

Comments
 (0)