FMA for Cannon updates for Go 1.23 and Kona #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mds1 merged 10 commits into main from pd/add-cannon-updates-for-go-1.23-and-kona-fma

Jun 17, 2025

Contributor

pauldowman commented May 2, 2025

Adds an FMA for Cannon updates for Go 1.23 and Kona.

Closes ethereum-optimism/release-management#323


          Begin FMA for Cannon updates for Go 1.23 and Kona

8e2145b

pauldowman mentioned this pull request

[U16] FMA for Cannon updates to support Go 1.23 and Kona ethereum-optimism/release-management#323

Closed


          Add failure modes to the go 1.23 and Kona FMA

62ccd22

Contributor Author

pauldowman commented May 7, 2025

@mbaxter could you take a look and see if you have anything to add or change?

mbaxter reviewed

View reviewed changes

Contributor

mbaxter left a comment

I think the feature toggles section might need to be adjusted a bit to reflect the latest code, but generally looks good to me 👍

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

pauldowman added 3 commits

May 11, 2025 19:31


          Fix FMA formatting and text changes

87012a8


          Include mprotect syscall in Cannon go 1.23 FMA

ef62213


          Set FMA status to In Review

e47fdc5

pauldowman changed the title ~~Begin FMA for Cannon updates for Go 1.23 and Kona~~ FMA for Cannon updates for Go 1.23 and Kona

pauldowman marked this pull request as ready for review

May 21, 2025 23:24

pauldowman requested a review from mds1

May 21, 2025 23:24

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Show resolved Hide resolved

pauldowman added 3 commits

June 3, 2025 14:20


          Add suggested updates for go 1.23 and kona FMA

574dcfc


          Add audit info to Cannon go 1.23 and Kona changes FMA

e674f8d


          Updated TOC for Cannon updates for Go 1.23 and Kona FMA

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved

mds1 reviewed

View reviewed changes

security/fma-cannon-updates-for-go-1.23-and-kona.md Outdated Show resolved Hide resolved


          Mark the "resolve comments" to-do item as done.

99fbb63

Co-authored-by: Matt Solomon <[email protected]>


          Mark Cannon Go 1.23 FMA as Final

adb50e5

Co-authored-by: Matt Solomon <[email protected]>

mds1 approved these changes

View reviewed changes

Contributor

mds1 left a comment

Thank you @pauldowman and @mbaxter!

mds1 merged commit e443b43 into main

4 checks passed

mds1 deleted the pd/add-cannon-updates-for-go-1.23-and-kona-fma branch

June 17, 2025 15:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet