feat(monitorism): Add ETH conservation invariant monitor #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
force-pushed
the
cl/eth-conservation
branch
from
5b5edc6 to
5c54481
Compare
clabby
commented
Mar 26, 2025
| @@ -35,7 +34,7 @@ func newCli(GitCommit string, GitDate string) *cli.App { | |||
| Usage: "OP Stack Monitoring", | |||
| Description: "OP Stack Monitoring", | |||
| EnableBashCompletion: true, | |||
| Version: params.VersionWithCommit(GitCommit, GitDate), | |||
There was a problem hiding this comment.
Note to reviewer - this doesn't exist anymore.
clabby
force-pushed
the
cl/eth-conservation
branch
2 times, most recently
from
88e9e9e to
ee4661a
Compare
clabby
force-pushed
the
cl/eth-conservation
branch
from
ee4661a to
9ac41de
Compare
clabby
commented
Mar 27, 2025
|
Accepting the lack of tests because our testing infra isn't so good and anvil doesn't support the debug namespaces |
|
Okay need to investigate why the CI is not triggering here @raffaele-oplabs tomorrow one of us got time there :) |
raffaele-oplabs
previously approved these changes
Apr 2, 2025
raffaele-oplabs
dismissed stale reviews from smartcontracts and themself
via
207efae
forcing circleci
forcing circleci
|
Interesting that the linter seems broken next week we should have a look and would go for the deployment around next week. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Ethnical
approved these changes
Apr 21, 2025
raffaele-oplabs
approved these changes
Apr 21, 2025
Ethnical
added a commit
that referenced
this pull request
Apr 21, 2025
* feat(monitorism): Add ETH conservation invariant monitor * Update README.md * Update README.md forcing circleci * Update README.md forcing circleci * chore: fix ci --------- Co-authored-by: Raffaele <[email protected]> Co-authored-by: ethnical <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new invariant monitor for the ETH conservation invariant. This is intended to serve alerts to the team if anything goes wrong with respect to fee calculation in the EVM.