chore: refactor out _apply_request_formatters #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
force-pushed
the
refactor
branch
2 times, most recently
from
4742932 to
41ef2ca
Compare
2 tasks
BobTheBuidler
commented
May 14, 2025
| if self.json_rpc_method in RPC_METHODS_UNSUPPORTED_DURING_BATCH: | ||
| raise MethodNotSupported( | ||
| f"Method `{self.json_rpc_method}` is not supported within a batch " | ||
| "request." | ||
| ) | ||
| return module.retrieve_request_information(self) | ||
| return module.retrieve_request_information(self) # type: ignore [return-value] |
There was a problem hiding this comment.
not really sure how to deal with the line len err here
|
This went beyond its original scope, I will break it up into smaller PRs and rebase it as they merge. |
BobTheBuidler
commented
May 16, 2025
| else formatted_dict | ||
| ) | ||
| formatted: Dict[str, Any] | ||
| formatted = apply_formatters_to_dict(formatters, value) # type: ignore [arg-type] |
There was a problem hiding this comment.
had to move this due to line len err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Nothing was wrong, but I noticed _apply_request_formatters is a private function only used in 1 place in the codebase, and not particularly efficient due to its unnecessary use of
toolz.pipeso I refactored it out completely.Related to Issue #N/A
Closes #N/A
How was it fixed?
replaced with a simple if check
Todo:
I did not add an entry to release notes as this change is not relevant for a typical user.
Cute Animal Picture