Skip to content

📚 DOCS: Fix docstring #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2020
Merged

Conversation

tsutsu3
Copy link
Contributor

@tsutsu3 tsutsu3 commented Dec 18, 2020

before:
before

after:
after

@tsutsu3
Copy link
Contributor Author

tsutsu3 commented Dec 18, 2020

Ref: actions/setup-python#171

@hukkin
Copy link
Contributor

hukkin commented Dec 18, 2020

Maybe change pypy3 to pypy-3.6 or pypy-3.7 (or both) in CI as suggested in actions/setup-python#171 (comment) ? That seems like the better syntax to me. It wasn't used originally here because it didn't exist yet at the time.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #99 (6a4ede2) into master (f016794) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   96.49%   96.49%   -0.01%     
==========================================
  Files          69       69              
  Lines        2911     2910       -1     
==========================================
- Hits         2809     2808       -1     
  Misses        102      102              
Flag Coverage Δ
pytests 96.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/main.py 90.98% <ø> (ø)
markdown_it/helpers/parse_link_label.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f016794...d2adc4b. Read the comment docs.

@tsutsu3
Copy link
Contributor Author

tsutsu3 commented Dec 18, 2020

Ref: actions/setup-python#171

It has been fixed to work with pypy3

@chrisjsewell
Copy link
Member

cheers, note it won't actually show in the documentation site until #101 is fixed

@chrisjsewell chrisjsewell changed the title Fix Example block appearance 📚 DOCS: Fix docstring Dec 19, 2020
@chrisjsewell chrisjsewell merged commit b232bf1 into executablebooks:master Dec 19, 2020
@tsutsu3 tsutsu3 deleted the fix/doc branch December 21, 2020 14:08
@tsutsu3 tsutsu3 restored the fix/doc branch December 21, 2020 14:09
@tsutsu3 tsutsu3 deleted the fix/doc branch December 21, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants