Fixed an issue where low quality M4A files were being redownloaded every time because a .flac file was expected but didn't exist. #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .flac when the extension should have been m4a. It would redownload content because the .flac file didn't exist. Previously, 'quality_audio' wasn't passed to dl.item(), causing incorrect extension guessing. Now it's correctly included in the download function and checks for the right file path.
This PR fixes two key issues: 1. skip_existing Bug – Previously, file extensions were incorrectly defaulting to .flac when checking for existing downloads, causing m4a files to be redownloaded. This is now fixed by ensuring quality_audio is correctly passed to dl.item(), allowing the extension to be determined properly. 2. Path Sanitization Issues – The path sanitization logic was incorrectly modifying filenames, sometimes stripping out the song name or replacing it with _01. The sanitization function has been fixed to retain proper filenames while still preventing invalid characters.
exislow
reviewed
Mar 23, 2025
There was a problem hiding this comment.
What I basically did is, I have taken you cli.py changes and applied it to the code. Unfortunately you cannot simplify the path_file_sanitize as you did. I guess, you have not done extensive testing. But no worries, maybe you can check if the bug still persists with the latest master code.
| dl.item( | ||
| media_id=item_id, | ||
| media_type=media_type, | ||
| file_template=file_template, | ||
| download_delay=download_delay, | ||
| quality_audio=quality_audio, |
There was a problem hiding this comment.
You are absolutely right. Thanks for this.
| @@ -208,82 +208,26 @@ def get_format_template( | |||
|
|
|||
|
|
|||
| def path_file_sanitize(path_file: pathlib.Path, adapt: bool = False, uniquify: bool = True) -> pathlib.Path: | |||
There was a problem hiding this comment.
This method is quite complex, and cannot be simplified like this.
It handles a lot of cases, e.g. filename shortenings and base dir changes, if the names are longer than the operating system allows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
quality_audioparameter was missing when callingdl.item(), causing incorrect file extension guessing..flac, even when downloadingm4a(<Quality.low_96k: 'LOW'>, <Quality.low_320k: 'HIGH'>), leading to unnecessary re-downloads.Fix
quality_audiois now correctly passed todl.item(), ensuring the proper extension is used when checking for existing files.skip_existingnow correctly looks for the expected file type.Impact
No more unnecessary redownloading of M4A files.
skip_existingnow correctly prevents duplicate downloads.