This repository was archived by the owner on Aug 13, 2022. It is now read-only.
#59 회원 단위테스트 추가 #124
Open
#59 회원 단위테스트 추가 #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-dev
reviewed
Oct 9, 2020
| @Test | ||
| public void 비밀번호_수정() throws Exception{ | ||
| //given | ||
| String encodePassword = passwordEncoder.encode(password); |
There was a problem hiding this comment.
passwordEncoder는 mock 객체인데 given-willReturn 처리가 안되어있네요. encoder의 동작도 정의를 해줘야합니다~
| @Test | ||
| public void 회원_추가() throws Exception{ | ||
| //when | ||
| accountService.addAccount(account); |
There was a problem hiding this comment.
여기서는 passwordEncodeCopyAccount 호출을 통해 새 객체를 insert하는것 같은데 해당 동작에 대한 커버가 되어있지 않네요. 다른 부분도 비즈니스로직에서 입력값에 대한 출력, 예외 등의 시나리오가 여러개가 있을 수 있습니다.
이런 시나리오들을 최대한 모두 정의해서 커버해주세요.
그럼 메소드명도 시나리오를 설명하는 형식으로 바뀌게 되겠죠~ (ex. 회원을 추가할때는 비밀번호를 암호화해서 insert 시킨다 등)
| } | ||
|
|
||
| @Test | ||
| public void 회원_추가() throws Exception{ |
There was a problem hiding this comment.
여기선 메소드명이 한글로 되어있는데 이것보다는 junit5에서 지원하는 테스트의 이름을 지을 수 있는 기능을 사용해보세요~
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.