-
-
Notifications
You must be signed in to change notification settings - Fork 9k
chore: bump typescript-eslint to v7 #10271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
*/ | ||
|
||
import {createRule} from '../util'; | ||
import type {TSESTree} from '@typescript-eslint/types/dist/ts-estree'; | ||
import type {TSESTree} from '@typescript-eslint/types'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Package exports were cleaned up in typescript-eslint v6: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6#package-exports |
||
|
||
const docsUrl = 'https://docusaurus.io/docs/docusaurus-core#link'; | ||
|
||
|
@@ -35,7 +35,6 @@ export default createRule<Options, MessageIds>({ | |
type: 'problem', | ||
docs: { | ||
description: 'enforce using Docusaurus Link component instead of <a> tag', | ||
recommended: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are no longer required in types for rules, and it looks to me that these weren't used anywhere in Docusaurus code. |
||
}, | ||
schema: [ | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I love this rule, it needs linting with type information to be bug-free. typescript-eslint/typescript-eslint#6397 changed the rule to require type info in typescript-eslint v6.
I briefly tried adding typed linting in this PR but:
parserOptions.project
resulted in out-of-memory exceptionsEXPERIMENTAL_useProjectService
resulted in 855 files complaining about not being included in the default project (i.e. fix(typescript-estree): don't add in-project files to defaultProjectMatchedFiles typescript-eslint/typescript-eslint#9097)...so my suggestion would be to wait until v8 to use the stabilized
parserOptions.projectService
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, we had a weird type checking setup (to make tests type checked), and I don't remember a good way to deal with it.