☂️ Help us Kotlin-ify React Native - Round 3

[mateoguzmana]

☂️ Help us Kotlin-ify React Native - Round 3

Hey all 👋
After the successful second round, we're back with another round of tasks to help us improve Kotlin support in React Native core. In this stage we are looking for help to migrate a few more files to Kotlin.

How to work

If you wish to grab one of the tasks, you should:

• Verify that the task is not claimed yet.
• Comment here that you claim a task.
• Start working on the task. Testing instructions are below.
• Send the PR for review. Ping @mateoguzmana, @cortinico or @mdvacca for a review.
• You can’t claim more than one task at a time.
• If you’re not completing the task within a week, we’ll release it for the next contributor.

Code formatting

Please use KtFmt to format Kotlin classes.
You can use the web UI to reformat directly from the browser.

Migrating files to Kotlin

Please act as follow:

• Fork and clone the repo
• Verify that RN-Tester, our reference app, runs with yarn && yarn android from the root folder
• Migrate the file to Kotlin
• Verify that RN-Tester runs again using the same command.

Other important things to take into account:

• Avoid using Hungarian notation for the variables when the file is migrated. E.g.: mMyAwesomeProperty should become myAwesomeProperty
• You might have to run the project in old architecture as well to ensure nothing breaks there when building. You can easily switch in the RN-Tester by setting newArchEnabled=false in packages/rn-tester/android/app/gradle.properties
• Tap around in a few screens after migrating (helps to ensure nothing is breaking at runtime)

List of files to migrate

• react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java assigned to @nitinshukla413
• react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java assigned to @gouravkhunger
• react/modules/blob/FileReaderModule.java assigned to @devanshsaini11
• react/modules/blob/BlobProvider.java assigned to @JatinDream11
• react/runtime/ReactLifecycleStateManager.java assigned to @rohitverma-d11
• react/views/textinput/ReactEditTextInputConnectionWrapper.java assigned to @Q1w1N
• react/uimanager/ReactClippingViewGroupHelper.java assigned to @Priyanka26012
• react/uimanager/ReactStylesDiffMap.java assigned to @poonamjain96
• react/bridge/UiThreadUtil.java assigned to @riteshshukla04
• react/bridge/DynamicFromObject.java assigned to @yasir6jan
• react/bridge/DynamicFromArray.java assigned to @BogiKay
• react/bridge/DynamicFromMap.java assigned to @artus9033

[cortinico]

Let's go 🚀

[devanshsaini11]

I would like to migrate: react/modules/blob/FileReaderModule.java

[JatinDream11]

I would like to migrate react/modules/blob/BlobProvider.java

[yasir6jan]

I would like to migrate react/bridge/DynamicFromObject.java

[poonamjain96]

I would like to migrate react/uimanager/ReactStylesDiffMap.java

[Q1w1N]

I would like to migrate react/views/textinput/ReactEditTextInputConnectionWrapper.java

[BogiKay]

I'd like to migrate react/bridge/DynamicFromArray.java

[artus9033]

Hello, I'd like to migrate react/bridge/DynamicFromMap.java

[rohitverma-d11]

Hello, I'd like to migrate react/runtime/ReactLifecycleStateManager.java

[riteshshukla04]

react/bridge/UiThreadUtil.java

Can you assign me this @mateoguzmana

[gouravkhunger]

Hi @mateoguzmana I could help with react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java

[nitinshukla413]

Can you assign me this @mateoguzmana
react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java

[Priyanka26012]

Can you assign me this @mateoguzmana
react/uimanager/ReactClippingViewGroupHelper.java

[mateoguzmana]

Thanks all for the interest so far! All the files have been assigned now. Let us know if you run into issues