Migrate UiThreadUtil to Kotlin #50536
Closed
+83
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico @mateoguzmana @mdvacca |
mateoguzmana
requested changes
Apr 7, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
|
@mateoguzmana Thanks for the review. I have fixed the comments |
mateoguzmana
reviewed
Apr 7, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
|
Done @mateoguzmana . Thanks. |
|
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
alanleedev
reviewed
Apr 7, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/UiThreadUtil.kt
Outdated
Show resolved
Hide resolved
mateoguzmana
approved these changes
Apr 8, 2025
|
@arushikesarwani94 merged this pull request in 1033584. |
|
This pull request was successfully merged by @riteshshukla04 in 1033584 When will my fix make it into a release? | How to file a pick request? |
12 tasks
|
Its merged 🎉. @mateoguzmana If you have more files , please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR aims to migrate UiThreadUtil from Java to kotlin as part of #50513
Changelog:
[ANDROID][CHANGED]Migrate UiThreadUtil to Kotlin
Test Plan:
Tested on RN tester with both new and old arch