Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNTester: Fix playground icon & test details button #50530

Closed

Conversation

mateoguzmana
Copy link
Collaborator

Summary:

Some minor fixes in the RNTester that were bugging me a bit:

  • Playground tab icon is not displaying the correct icon when the tab is active.
  • The RNTTestDetails button is being displayed when there is nothing to display.
  • Export the data for the Playground tab correctly to display the description.

Changelog:

[INTERNAL] - RNTester: Fix playground icon & test details button

Test Plan:

Screenshots
Before After
Screenshot_1744044385 Screenshot_1744044377

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 7, 2025
@mateoguzmana mateoguzmana marked this pull request as draft April 7, 2025 16:51
Comment on lines +136 to +137
NavBarPlaygroundActiveIcon: require('./../assets/bottom-nav-playgrounds-icon-light.png'),
NavBarPlaygroundInactiveIcon: require('./../assets/bottom-nav-playgrounds-icon-dark.png'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mateoguzmana mateoguzmana marked this pull request as ready for review April 7, 2025 17:17
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 9, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 0617acc.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mateoguzmana in 0617acc

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants