Skip to content

RNTester: Fix playground icon & test details button #50530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+28 −26
Closed

RNTester: Fix playground icon & test details button #50530

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
950bd7c
Fix active playground icon in dark mode
mateoguzmana Apr 6, 2025
ddd2838
RNTester: Fix collpase button content logic
mateoguzmana Apr 6, 2025
ebc70fc
Revert unnnecessary changes
mateoguzmana Apr 7, 2025
5a0d25b
Merge branch 'main' of github.com:mateoguzmana/react-native into fix/…
mateoguzmana Apr 7, 2025
271efb6
Revert unnecessary EOL
mateoguzmana Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions packages/rn-tester/js/components/RNTTestDetails.js
View file
Original file line number Diff line number Diff line change
@@ -25,30 +25,31 @@ function RNTTestDetails({
}): React.Node {
const [collapsed, setCollapsed] = React.useState(true);

const content = (
<>
{description == null ? null : (
<View style={styles.section}>
<Text style={[styles.heading, {color: theme.LabelColor}]}>
Description
</Text>
<Text style={[styles.paragraph, {color: theme.LabelColor}]}>
{description}
</Text>
</View>
)}
{expect == null ? null : (
<View style={styles.section}>
<Text style={[styles.heading, {color: theme.LabelColor}]}>
Expectation
</Text>
<Text style={[styles.paragraph, {color: theme.LabelColor}]}>
{expect}
</Text>
</View>
)}
</>
);
const content =
description == null && expect == null ? null : (
<>
{description == null ? null : (
<View style={styles.section}>
<Text style={[styles.heading, {color: theme.LabelColor}]}>
Description
</Text>
<Text style={[styles.paragraph, {color: theme.LabelColor}]}>
{description}
</Text>
</View>
)}
{expect == null ? null : (
<View style={styles.section}>
<Text style={[styles.heading, {color: theme.LabelColor}]}>
Expectation
</Text>
<Text style={[styles.paragraph, {color: theme.LabelColor}]}>
{expect}
</Text>
</View>
)}
</>
);
return (
<View
style={StyleSheet.compose(styles.container, {
4 changes: 2 additions & 2 deletions packages/rn-tester/js/components/RNTesterTheme.js
View file
Original file line number Diff line number Diff line change
@@ -133,8 +133,8 @@ export const RNTesterDarkTheme = {
NavBarComponentsInactiveIcon: require('./../assets/bottom-nav-components-icon-dark.png'),
NavBarAPIsActiveIcon: require('./../assets/bottom-nav-apis-icon-light.png'),
NavBarAPIsInactiveIcon: require('./../assets/bottom-nav-apis-icon-dark.png'),
NavBarPlaygroundActiveIcon: require('./../assets/bottom-nav-playgrounds-icon-dark.png'),
NavBarPlaygroundInactiveIcon: require('./../assets/bottom-nav-playgrounds-icon-light.png'),
NavBarPlaygroundActiveIcon: require('./../assets/bottom-nav-playgrounds-icon-light.png'),
NavBarPlaygroundInactiveIcon: require('./../assets/bottom-nav-playgrounds-icon-dark.png'),
Comment on lines +136 to +137
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

};

export const themes = {light: RNTesterLightTheme, dark: RNTesterDarkTheme};
1 change: 1 addition & 0 deletions packages/rn-tester/js/examples/Playground/RNTesterPlayground.js
View file
Original file line number Diff line number Diff line change
@@ -34,5 +34,6 @@ const styles = StyleSheet.create({
export default ({
title: 'Playground',
name: 'playground',
description: 'Test out new features and ideas.',
render: (): React.Node => <Playground />,
}: RNTesterModuleExample);

Unchanged files with check annotations Beta

View file
flow-typed/environment/node.js
fromEnc: buffer$Encoding,
toEnc: buffer$Encoding,
): Node$Buffer;
declare var Buffer: Node$Buffer;

Check warning on line 200 in flow-typed/environment/node.js

GitHub Actions / test_js (22) 

'Buffer' is already declared in the upper scope on line 53 column 15

Check warning on line 200 in flow-typed/environment/node.js

GitHub Actions / test_js (20) 

'Buffer' is already declared in the upper scope on line 53 column 15

Check warning on line 200 in flow-typed/environment/node.js

GitHub Actions / test_js (18) 

'Buffer' is already declared in the upper scope on line 53 column 15
}
type child_process$execOpts = {
View file
flow-typed/npm/jest.js
// Modifications are explained inline by comments beginning with `// MODIFIED`.
// MODIFIED: Added ESLint suppression comment - no-unused-vars doesn't understand declaration files
/* eslint-disable no-unused-vars */

Check warning on line 15 in flow-typed/npm/jest.js

GitHub Actions / test_js (22) 

'no-unused-vars' rule is disabled but never reported

Check warning on line 15 in flow-typed/npm/jest.js

GitHub Actions / test_js (20) 

'no-unused-vars' rule is disabled but never reported

Check warning on line 15 in flow-typed/npm/jest.js

GitHub Actions / test_js (18) 

'no-unused-vars' rule is disabled but never reported
type JestMockFn<TArguments: $ReadOnlyArray<mixed>, TReturn> = {
(...args: TArguments): TReturn,
View file
packages/assets/registry.js
return assets[assetId - 1];
}
module.exports = {registerAsset, getAssetByID};

Check warning on line 43 in packages/assets/registry.js

GitHub Actions / test_js (22) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 43 in packages/assets/registry.js

GitHub Actions / test_js (20) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 43 in packages/assets/registry.js

GitHub Actions / test_js (18) 

Use `export` syntax instead of CommonJS `module.exports`
View file
packages/dev-middleware/src/inspector-proxy/Device.js
const debug = require('debug')('Metro:InspectorProxy');
const PAGES_POLLING_INTERVAL = 1000;
const MIN_MESSAGE_QUEUE_BYTES_TO_REPORT = 2 * 1024 * 1024; // 2 MiB

Check warning on line 40 in packages/dev-middleware/src/inspector-proxy/Device.js

GitHub Actions / test_js (22) 

'MIN_MESSAGE_QUEUE_BYTES_TO_REPORT' is assigned a value but never used

Check warning on line 40 in packages/dev-middleware/src/inspector-proxy/Device.js

GitHub Actions / test_js (20) 

'MIN_MESSAGE_QUEUE_BYTES_TO_REPORT' is assigned a value but never used

Check warning on line 40 in packages/dev-middleware/src/inspector-proxy/Device.js

GitHub Actions / test_js (18) 

'MIN_MESSAGE_QUEUE_BYTES_TO_REPORT' is assigned a value but never used
const WS_CLOSURE_CODE = {
NORMAL: 1000,
View file
packages/polyfills/console.js
'use client';
/* eslint-disable no-shadow, eqeqeq, curly, no-unused-vars, no-void, no-control-regex */

Check warning on line 14 in packages/polyfills/console.js

GitHub Actions / test_js (22) 

'curly' rule is disabled but never reported

Check warning on line 14 in packages/polyfills/console.js

GitHub Actions / test_js (20) 

'curly' rule is disabled but never reported

Check warning on line 14 in packages/polyfills/console.js

GitHub Actions / test_js (18) 

'curly' rule is disabled but never reported
/**
* This pipes all of our console logging functions to native logging so that
View file
packages/react-native-compatibility-check/src/__tests__/TypeDiffing-test.js
nativeTypeDiffingTypesAliases,
nativeTypeDiffingTypesMethodParamLookup,
nativeTypeDiffingTypesMethodLookup,
_,

Check warning on line 85 in packages/react-native-compatibility-check/src/__tests__/TypeDiffing-test.js

GitHub Actions / test_js (22) 

'_' is assigned a value but never used

Check warning on line 85 in packages/react-native-compatibility-check/src/__tests__/TypeDiffing-test.js

GitHub Actions / test_js (20) 

'_' is assigned a value but never used

Check warning on line 85 in packages/react-native-compatibility-check/src/__tests__/TypeDiffing-test.js

GitHub Actions / test_js (18) 

'_' is assigned a value but never used
nativeTypeDiffingTypesEnums,
] = getModule(
'native-module-type-diffing-types',
View file
packages/react-native/Libraries/Animated/animations/Animation.js
import type AnimatedValue from '../nodes/AnimatedValue';
import NativeAnimatedHelper from '../../../src/private/animated/NativeAnimatedHelper';
import * as ReactNativeFeatureFlags from '../../../src/private/featureflags/ReactNativeFeatureFlags';

Check warning on line 16 in packages/react-native/Libraries/Animated/animations/Animation.js

GitHub Actions / test_js (22) 

'ReactNativeFeatureFlags' is defined but never used

Check warning on line 16 in packages/react-native/Libraries/Animated/animations/Animation.js

GitHub Actions / test_js (20) 

'ReactNativeFeatureFlags' is defined but never used

Check warning on line 16 in packages/react-native/Libraries/Animated/animations/Animation.js

GitHub Actions / test_js (18) 

'ReactNativeFeatureFlags' is defined but never used
import AnimatedProps from '../nodes/AnimatedProps';
export type EndResult = {finished: boolean, value?: number, ...};
View file
packages/react-native/Libraries/Animated/nodes/AnimatedValue.js
* transform which can receive values from multiple parents.
*/
export function flushValue(rootNode: AnimatedNode): void {
// eslint-disable-next-line func-call-spacing

Check warning on line 55 in packages/react-native/Libraries/Animated/nodes/AnimatedValue.js

GitHub Actions / test_js (22) 

'func-call-spacing' rule is disabled but never reported

Check warning on line 55 in packages/react-native/Libraries/Animated/nodes/AnimatedValue.js

GitHub Actions / test_js (20) 

'func-call-spacing' rule is disabled but never reported

Check warning on line 55 in packages/react-native/Libraries/Animated/nodes/AnimatedValue.js

GitHub Actions / test_js (18) 

'func-call-spacing' rule is disabled but never reported
const leaves = new Set<{update: () => void, ...}>();
function findAnimatedStyles(node: AnimatedNode) {
// $FlowFixMe[prop-missing]
View file
packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestConfig.js
remoteModuleConfig: remoteModulesConfig,
};
module.exports = MessageQueueTestConfig;

Check warning on line 38 in packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestConfig.js

GitHub Actions / test_js (22) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 38 in packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestConfig.js

GitHub Actions / test_js (20) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 38 in packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestConfig.js

GitHub Actions / test_js (18) 

Use `export` syntax instead of CommonJS `module.exports`
View file
packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestModule.js
testHook2: function () {},
};
module.exports = MessageQueueTestModule;

Check warning on line 22 in packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestModule.js

GitHub Actions / test_js (22) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 22 in packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestModule.js

GitHub Actions / test_js (20) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 22 in packages/react-native/Libraries/BatchedBridge/__mocks__/MessageQueueTestModule.js

GitHub Actions / test_js (18) 

Use `export` syntax instead of CommonJS `module.exports`