Skip to content

cli assemble support #44903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

cli assemble support #44903

wants to merge 3 commits into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Jun 12, 2024

Summary:
Call our wrapper to assemble an Android build of helloworld.

Changelog: [Internal]

Differential Revision: D58287785

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58287785

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58287785

@blakef blakef force-pushed the export-D58287785 branch from 429cf33 to 92a9b56 Compare June 12, 2024 15:01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58287785

@blakef blakef force-pushed the export-D58287785 branch from 92a9b56 to 0b701a4 Compare June 12, 2024 16:11
@analysis-bot
Copy link

analysis-bot commented Jun 12, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,364,338 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,568 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b19bf2b
Branch: main

blakef added 2 commits June 13, 2024 00:31
Summary:
Pull Request resolved: #44902

Add support for building (assembling) a React Native Android project.

Changelog: [General][Added] core-cli-utils Android support

Differential Revision: D58287783
…orld] cli assemble support" - Gradle Changes

Summary:
Point Gradle to the monorepo instead of a node_modules, as well as remove some commented out entries we're not interested in.

Changelog: [Internal]

Differential Revision: D58287786
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58287785

@blakef blakef force-pushed the export-D58287785 branch from 0b701a4 to cadf80f Compare June 13, 2024 07:40
Summary:
Pull Request resolved: #44903

Call our wrapper to assemble an Android build of helloworld.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D58287785
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58287785

@blakef blakef force-pushed the export-D58287785 branch from cadf80f to 5159c31 Compare June 13, 2024 07:47
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6970854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants