Fork onPress callbacks for ios highlighting #44909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58391419 |
Base commit: 18be49e |
Summary: Pull Request resolved: facebook#44909 Today we wrap all `onPressIn` and `onPressOut` callbacks we pass to pressability so we can set the `highlighted` state. However highlighted state is only ever set to anything other that false on iOS. This change not only skips calling `setHighlighted(false)` on every press event but also skips wrapping the callback. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D58391419
|
This pull request was exported from Phabricator. Differential Revision: D58391419 |
pieterv
force-pushed
the
export-D58391419
branch
from
136cf58 to
4c0deb3
Compare
|
This pull request has been merged in f7aea0c. |
|
This pull request was successfully merged by @pieterv in f7aea0c. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Today we wrap all
onPressInandonPressOutcallbacks we pass to pressability so we can set thehighlightedstate. However highlighted state is only ever set to anything other that false on iOS. This change not only skips callingsetHighlighted(false)on every press event but also skips wrapping the callback.Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D58391419