Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java #50359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GijsWeterings
Copy link
Contributor

Summary:
Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 4, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@GijsWeterings GijsWeterings force-pushed the export-D71979578 branch 2 times, most recently from e7b24a9 to 3aedebe Compare April 7, 2025 09:34
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 7, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 8, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 8, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 8, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 8, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@GijsWeterings GijsWeterings force-pushed the export-D71979578 branch 2 times, most recently from 5046a34 to fdc3d95 Compare April 9, 2025 09:36
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 9, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 9, 2025
…ages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D71979578
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71979578

GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Apr 9, 2025
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359)

Summary:
Pull Request resolved: facebook#50359

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Differential Revision: D71979578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants