Skip to content

Make SurfaceHandler internal #50502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make SurfaceHandler internal #50502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2565,15 +2565,6 @@ public abstract interface class com/facebook/react/interfaces/fabric/ReactSurfac
public abstract fun stop ()Lcom/facebook/react/interfaces/TaskInterface;
}

public abstract interface class com/facebook/react/interfaces/fabric/SurfaceHandler {
public abstract fun getModuleName ()Ljava/lang/String;
public abstract fun getSurfaceId ()I
public abstract fun isRunning ()Z
public abstract fun setLayoutConstraints (IIIIZZF)V
public abstract fun setMountable (Z)V
public abstract fun setProps (Lcom/facebook/react/bridge/NativeMap;)V
}

public final class com/facebook/react/jscexecutor/JSCExecutor : com/facebook/react/bridge/JavaScriptExecutor {
public fun getName ()Ljava/lang/String;
public static final fun loadLibrary ()V
Expand Down
14 changes: 7 additions & 7 deletions ...-native/ReactAndroid/src/main/java/com/facebook/react/interfaces/fabric/SurfaceHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,21 @@ import javax.annotation.concurrent.ThreadSafe

/** Represents a Java variant of the surface, its status and inner data required to display it. */
@ThreadSafe
public interface SurfaceHandler {
internal interface SurfaceHandler {

/**
* Provides current surface id. Id should be updated after each call to {@link
* SurfaceHandler#stop}
*/
public val surfaceId: Int
val surfaceId: Int

public val isRunning: Boolean
val isRunning: Boolean

public val moduleName: String
val moduleName: String

public fun setProps(props: NativeMap)
fun setProps(props: NativeMap)

public fun setLayoutConstraints(
fun setLayoutConstraints(
widthMeasureSpec: Int,
heightMeasureSpec: Int,
offsetX: Int,
Expand All @@ -36,5 +36,5 @@ public interface SurfaceHandler {
pixelDensity: Float
)

public fun setMountable(mountable: Boolean)
fun setMountable(mountable: Boolean)
}
Loading