Avoid build failure on Catalyst (x86_64) #50514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When building React Native for mac catalyst on intel architecture, we are observing a build failure in RCTInstance. See issue: facebook#50388 Apparently, the compiler don't understand that `errorData[@"isFatal"]` is a BOOL, so we are helping it by extracting the `boolValue`. ## Changelog: [iOS][Fixed] - Avoid build failure on Catalyst (x86_64) Differential Revision: D72558024
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72558024 |
|
This pull request has been merged in 0f53429. |
|
This pull request was successfully merged by @cipolleschi in 0f53429 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When building React Native for mac catalyst on intel architecture, we are observing a build failure in RCTInstance.
See issue: #50388
Apparently, the compiler don't understand that
errorData[@"isFatal"]is a BOOL, so we are helping it by extracting theboolValue.Changelog:
[iOS][Fixed] - Avoid build failure on Catalyst (x86_64)
Differential Revision: D72558024