Make ModuleDataCleaner internal
#51060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@arushikesarwani94 merged this pull request in 6fa1864. |
|
This pull request was successfully merged by @mateoguzmana in 6fa1864 When will my fix make it into a release? | How to file a pick request? |
|
I believe this coudl be a little more disruptive actually: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are no relevant OSS usages.
Only one library uses it (https://github.com/jbrodriguez/react-native-android-sqlite), but it's hasn't been updated for 10 years. Marking it as breaking, but it's unlikely that the library is used nowadays. See:
Changelog:
[ANDROID][BREAKING] - Make com.facebook.react.modules.common.ModuleDataCleaner internal
Test Plan: