Remove redundant files before ingestion #13484
Open
+285
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
jowlyzhang
force-pushed
the
dedupe_ingested_files
branch
from
79c4bbb to
7de7fea
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
jowlyzhang
force-pushed
the
dedupe_ingested_files
branch
from
7de7fea to
e529021
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
jowlyzhang
force-pushed
the
dedupe_ingested_files
branch
from
e529021 to
a6d9608
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
jowlyzhang
changed the title
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some logic in the ExternalSstFileIngestionJob::Prepare step to remove redundant files before ingestion. It takes care of two types of redundant files: 1) standalone range deletion file that contains the exactly same range deletion as a previous file, 2) data files that are already range deleted by some follow up file.
Our user's eventual call to
IngestExternalFilefor replacing old data could end up with this pattern where there are multiple range deletion files and multiple data files chained and it's not possible for them to deduplicate. So we add this change in RocksDB to remove redundant files before ingestion and simplify the scenarios our compaction picking optimization for standalone range deletion file need to deal with.Test plan:
Added tests