Update abandoned web-token dependencies #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warning about abandoned packages by replacing them with web-token/jwt-library Package web-token/jwt-checker is abandoned, you should avoid using it. Use web-token/jwt-library instead. Package web-token/jwt-core is abandoned, you should avoid using it. Use web-token/jwt-library instead. Package web-token/jwt-encryption is abandoned, you should avoid using it. Use web-token/jwt-library instead. Package web-token/jwt-key-mgmt is abandoned, you should avoid using it. Use web-token/jwt-library instead. Package web-token/jwt-signature is abandoned, you should avoid using it. Use web-token/jwt-library instead. Package web-token/jwt-signature-algorithm-rsa is abandoned, you should avoid using it. Use web-token/jwt-library instead. require PHP 8.1 or higher
Jean85
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Same review as facile-it/php-jose-verifier#14
We need to decide if and how we want to proceed with this.
| "web-token/jwt-signature-algorithm-experimental": "^2.0 || ^3.0", | ||
| "web-token/jwt-signature-algorithm-hmac": "^2.0 || ^3.0", | ||
| "web-token/jwt-signature-algorithm-none": "^2.0 || ^3.0" | ||
| "web-token/jwt-library": "^2.0 || ^3.0" |
There was a problem hiding this comment.
Duplicating the dependency doesn't make sense
Suggested change
| "web-token/jwt-library": "^2.0 || ^3.0" |
| "web-token/jwt-key-mgmt": "^2.0.7 || ^3.0", | ||
| "web-token/jwt-signature": "^2.0 || ^3.0", | ||
| "web-token/jwt-signature-algorithm-rsa": "^2.0 || ^3.0" | ||
| "web-token/jwt-library": "^2.0 || ^3.0" |
There was a problem hiding this comment.
This doesn't make sense, this package exists only since 3.3: https://packagist.org/packages/web-token/jwt-library
Suggested change
| "web-token/jwt-library": "^2.0 || ^3.0" | |
| "web-token/jwt-library": "^3.3" |
|
Resolved in #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning about abandoned packages by replacing them with
web-token/jwt-libraryI noticed there is a
composer.lockfile. It is not common to include thecomposer.lockfor libraries. It should probably be removed and added to.gitignoreI think after that the tests would pass.I now see that
web-token/jwt-library[3.3.0, ..., 3.3.1] require php >=8.1so you might need to release a new version that dropped support for PHP 7.4 and 8.0