Simple PyTorch extension API #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanFSchulte
requested changes
Mar 31, 2025
| first = node.get_input_node() | ||
| second = node | ||
|
|
||
| model.remove_node(first, rewire=True) |
There was a problem hiding this comment.
I think the rewire parameter doesn't do anything anymore, might be good to just not include it here if people end up using this as an example.
There was a problem hiding this comment.
I have probably copy/pasted that line from one of the other optimizers. Should I replace all instances of this? I see there's a few around
There was a problem hiding this comment.
Might be good to clean this up in general. I'm not sure why we have this around at all anymore, since the parameter is really just a dummy according to https://github.com/fastmachinelearning/hls4ml/blob/main/hls4ml/model/graph.py#L520-L537
JanFSchulte
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The equivalent of Keras extension API for PyTorch. The least hacky way of doing it, but only limited to custom modules. The custom modules should extend
hls4ml.utils.torch.HLS4MLModule(itself atorch.nn.Module). I borrowed theCustomFXTracerchange from #1019 and moved it to a different location, since the file containsHLS4MLModuleclass intended to be used by the user.Type of change
Tests
Test is included in
test_extensions_pytorch.pyChecklist
pre-commiton the files I edited or added.