This repository was archived by the owner on Feb 1, 2020. It is now read-only.
Add Cuda RNN FFI #12
Merged
Add Cuda RNN FFI #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added training reserve size & updated rnn_forward_training to use a Vec in API call
Added convenience function for Vec<Tensor> -> Vec<Tensor_C>
|
I'll do another round of code review tomorrow if everything goes well :) |
|
There is one warning regarding a deprecation warning using |
|
Looks good! |
drahnr
approved these changes
Jan 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds locally on latest Rust Stable (stable-x86_64-pc-windows-gnu) with opt-3.
Clippy throws warnings about marking functions that reference a unsafe{} block as unsafe, but otherwise no major issues.