Skip to content
This repository was archived by the owner on Feb 1, 2020. It is now read-only.

Add Cuda RNN FFI #12

Merged
merged 13 commits into from
Jan 11, 2020
Merged

Add Cuda RNN FFI #12

merged 13 commits into from
Jan 11, 2020

Conversation

lissahyacinth
Copy link
Contributor

Builds locally on latest Rust Stable (stable-x86_64-pc-windows-gnu) with opt-3.

Clippy throws warnings about marking functions that reference a unsafe{} block as unsafe, but otherwise no major issues.

@drahnr
Copy link
Member

drahnr commented Jan 9, 2020

I'll do another round of code review tomorrow if everything goes well :)

@drahnr
Copy link
Member

drahnr commented Jan 10, 2020

There is one warning regarding a deprecation warning using max_align_t which would be super if we could get rid of as well :)
Other than that, I'd say this is good to get merged 🍾

@drahnr
Copy link
Member

drahnr commented Jan 11, 2020

Looks good!

@drahnr drahnr self-requested a review January 11, 2020 06:32
@drahnr drahnr merged commit 3c8c266 into fff-rs:master Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants