Fix: Correct @ffmpeg/core-mt version in download-assets.js #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.12.10 doesn't exist for core-mt: https://registry.npmjs.org/@ffmpeg/core-mt/-/core-mt-0.12.10.tgz 0.12.9 is the latest version according to https://www.npmjs.com/package/@ffmpeg/core-mt
✅ Deploy Preview for ffmpegwasm canceled.
|
|
Fixes #861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CORE_MT_VERSIONconstant inscripts/download-assets.jswas set to0.12.10, which is not a published version for@ffmpeg/core-mt. This caused the script to fail when trying to download the non-existent asset (core-mt-0.12.10.tgz).This commit updates the version to
0.12.9, which is the latest available version according to npm (https://www.npmjs.com/package/@ffmpeg/core-mt), allowing the script to execute successfully.0.12.10(https://registry.npmjs.org/@ffmpeg/core-mt/-/core-mt-0.12.10.tgz - Not Found)0.12.9(https://registry.npmjs.org/@ffmpeg/core-mt/-/core-mt-0.12.9.tgz)