Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improved performance when opening path bar flyouts #16665

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Dec 31, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

  1. Navigated between multiple folders until the back & forward stack contained a bunch of items
  2. Right clicked the back and forward buttons
  3. Confirmed the thumbnails are 'lazy' loaded
  4. Clicked the expand chevron on the path bar and confirmed the menu flyout opens quicker

@yaira2 yaira2 requested a review from d2dyno1 December 31, 2024 21:39
@yaira2 yaira2 requested a review from gave92 January 1, 2025 02:09
{
public sealed class ToolbarFlyoutOpeningEventArgs
{
public MenuFlyout OpeningFlyout { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this get; only and inject through a constructor

@yaira2 yaira2 requested a review from d2dyno1 January 2, 2025 03:20
@Josh65-2201
Copy link
Member

Is the files app launcher suppose to be changed in this?

@yaira2
Copy link
Member Author

yaira2 commented Jan 2, 2025

Yes, I forgot to update them with 8436c6d

@yaira2 yaira2 merged commit fa4939d into main Jan 2, 2025
8 checks passed
@yaira2 yaira2 deleted the ya/ImproveFlyoutPerf branch January 2, 2025 21:44
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants